-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spaces in profile name in URL #39
Comments
On my end, the spaces are converted to a %20 and the page still works as expected upon refresh. Are you experiencing something different? |
Refresh still works but the space persists in the fragment on Firefox (at least visually, maybe it's a sneaky percent encoded value but I don't think so). |
Maybe it's best to resolve this by just implementing #34? |
Quite possibly. On Chrome, it's showing the %20 in place of the space. Either way though, the fragment isn't sent to the server, so whether or not it shows up from a technical perspective doesn't matter. The only issue this will cause (as far as I know) is when someone copies and pastes the URL into something like Slack or Discord and the respective platforms don't convert the whole thing to a link. I recommend that we fix this by implementing #34 |
Closing as a non-issue; let's focus on #34 |
A space in the profile name will cause a space in the fragment in the URL.
The text was updated successfully, but these errors were encountered: