Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces in profile name in URL #39

Closed
dbluhm opened this issue Oct 4, 2023 · 5 comments
Closed

Spaces in profile name in URL #39

dbluhm opened this issue Oct 4, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@dbluhm
Copy link
Member

dbluhm commented Oct 4, 2023

A space in the profile name will cause a space in the fragment in the URL.

@dbluhm dbluhm converted this from a draft issue Oct 4, 2023
@dbluhm dbluhm added the bug Something isn't working label Oct 4, 2023
@dbluhm dbluhm moved this from Wishlist to Urgent in DIDComm Education Oct 4, 2023
@TheTechmage
Copy link
Collaborator

On my end, the spaces are converted to a %20 and the page still works as expected upon refresh. Are you experiencing something different?

@dbluhm
Copy link
Member Author

dbluhm commented Oct 5, 2023

Refresh still works but the space persists in the fragment on Firefox (at least visually, maybe it's a sneaky percent encoded value but I don't think so).

@dbluhm
Copy link
Member Author

dbluhm commented Oct 5, 2023

Maybe it's best to resolve this by just implementing #34?

@TheTechmage
Copy link
Collaborator

Quite possibly. On Chrome, it's showing the %20 in place of the space. Either way though, the fragment isn't sent to the server, so whether or not it shows up from a technical perspective doesn't matter. The only issue this will cause (as far as I know) is when someone copies and pastes the URL into something like Slack or Discord and the respective platforms don't convert the whole thing to a link.

I recommend that we fix this by implementing #34

@dbluhm
Copy link
Member Author

dbluhm commented Oct 5, 2023

Closing as a non-issue; let's focus on #34

@dbluhm dbluhm closed this as completed Oct 5, 2023
@github-project-automation github-project-automation bot moved this from Urgent to Done in DIDComm Education Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants