Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly inaccurate document description #1409

Closed
hyLim6519 opened this issue Aug 6, 2024 · 2 comments
Closed

Possibly inaccurate document description #1409

hyLim6519 opened this issue Aug 6, 2024 · 2 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@hyLim6519
Copy link

Bug severity
3

Describe the bug
Not a bug on code but rather on documentation (markdown). It came to my notice that the documentation for mediation-manager markdown potentially have some flaw on the explanation on the coordinate mediation setup.

Observed behaviour

By default, the `isMediateGrantAll` policy is set to `true` meaning that any requests for mediation will be `GRANTED` unless their `did` is listed in the `preRequestPolicyStore` as `ALLOW`. Conversely, if the `isMediateGrantAll` policy is set to `false`, all requests will be allowed, unless they are listed in the `preRequestPolicyStore` as `ALLOW`.

Expected behaviour

By default, the `isMediateGrantAll` policy is set to `true` meaning that any requests for mediation will be `GRANTED` unless their `did` is listed in the `preRequestPolicyStore` as 
- `ALLOW` 
+ `DENY`.
Conversely, if the `isMediateGrantAll` policy is set to `false`, 
- all requests will be allowed, unless they are listed in the `preRequestPolicyStore` as `ALLOW`.
+ all requests for mediation will be `DENIED` , unless they are listed in the `preRequestPolicyStore` as `ALLOW`.

Additional context
The above is derived based on specification

@hyLim6519 hyLim6519 added the bug Something isn't working label Aug 6, 2024
@nickreynolds
Copy link
Contributor

I'd agree with you here. Feel free to put up a PR to fix this, or I'll get to it when I have a chance

Copy link

stale bot commented Nov 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 9, 2024
@stale stale bot closed this as completed Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants