internal: Add libsecp256k1 c library. #2810
Conversation
dex/libsecp256k1/libsecp256k1.go
Outdated
| copy(nonce[:], encode.RandomBytes(32)) | ||
| key := [32]byte{} | ||
| copy(key[:], privKey.Serialize()) | ||
| n := (*C.uchar)(unsafe.Pointer(&nonce)) |
There was a problem hiding this comment.
Am I supposed to use C.free on these?
JoeGruffins
force-pushed
the
addlibsecp256k1library
branch
2 times, most recently
from
6448f91 to
8e7f104
Compare
|
I guess this doesn't work as an external package as is because the c code must be built. Was there a way to ensure it is built? Also doesn't currently work on windows and maybe osx. Maybe best to move to internal anyway for now? |
JoeGruffins
force-pushed
the
addlibsecp256k1library
branch
from
8e7f104 to
be12d55
Compare
JoeGruffins
changed the title
|
Moved to internal which should mean it cannot be imported by other projects. |
|
If this becomes part of the build we'll need to remove it from our https://github.com/decred/release release builder. The cross compilation depends on the project being pure go. |
This will only be used by a separate monero proof of concept app. We are going to develop something in go for the client/server later, in a different proposal. We intend for this to be temporary. |
JoeGruffins
force-pushed
the
addlibsecp256k1library
branch
from
be12d55 to
4c89d42
Compare
JoeGruffins
force-pushed
the
addlibsecp256k1library
branch
from
4c89d42 to
490ec36
Compare
|
Added four more methods. |
JoeGruffins
force-pushed
the
addlibsecp256k1library
branch
2 times, most recently
from
5a31ba1 to
b1564c3
Compare
JoeGruffins
force-pushed
the
addlibsecp256k1library
branch
2 times, most recently
from
f1ef19b to
fcb1ff6
Compare
JoeGruffins
force-pushed
the
addlibsecp256k1library
branch
from
fcb1ff6 to
e67b1dc
Compare
JoeGruffins
force-pushed
the
addlibsecp256k1library
branch
2 times, most recently
from
ba9a320 to
c3463b3
Compare
JoeGruffins
force-pushed
the
addlibsecp256k1library
branch
from
c3463b3 to
fb4fafc
Compare
Add a c library that has some primitive cryptographic functions needed for working with adaptor signatures.
JoeGruffins
force-pushed
the
addlibsecp256k1library
branch
from
fb4fafc to
654e79a
Compare
Add a c library that has some primitive cryptographic functions needed for working with adaptor signatures.
part of #2754