backend: Add scalable PostgreSQL backend #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amass01
commented
Aug 5, 2020
| @@ -934,33 +934,34 @@ func (fs *FileSystem) LastAnchor() (*backend.LastAnchorResult, error) { | |||
| var fr *backend.FlushRecord | |||
| var me backend.LastAnchorResult | |||
| payload, err := db.Get([]byte(flushedKey), nil) | |||
| if err == nil { | |||
There was a problem hiding this comment.
Changed from:
if err == nil {
} else {
}
to:
if err != nil {
}
the else logic here...
lukebp
reviewed
Aug 18, 2020
amass01
commented
Aug 27, 2020
amass01
commented
Aug 30, 2020
amass01
changed the title
amass01
commented
Aug 30, 2020
| // | ||
| // See loadConfig for details on the configuration load process. | ||
| type config struct { | ||
| HomeDir string `short:"A" long:"appdata" description:"Path to application home directory"` |
There was a problem hiding this comment.
can we avoid listing all dcrtimed params here and use only the subset we need ? 🤔
amass01
commented
Aug 30, 2020
when postgres is used as BE
amass01
force-pushed
the
postgresBackend
branch
from
22b8119
to
7f78482
Compare
dajohi
reviewed
Sep 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff adds PostgreSQL implementation of dcrtimed's Backend interface.
Additionally, It extends
dcrtime_fsck,dcrtime_dumpdb&dcrtime_dumpdb -restoretosupport postgres backend as well.
The mentioned cmd tools dig in
dcrtimed.confto determine which backend torun and to find out the db connection params.
Closes #24