ticketvote: Fix summary best block bug.

lukebp · web-flow · commit b4b89de58e4c · 2021-04-20T11:45:20.000-05:00
This diff fixes a bug that was causing the best block in a vote summary
to not be accurate when the summary was being pulled from the cache.
diff --git a/politeiad/backendv2/tstorebe/plugins/ticketvote/cmds.go b/politeiad/backendv2/tstorebe/plugins/ticketvote/cmds.go
@@ -2400,7 +2400,8 @@ func (p *ticketVotePlugin) summary(token []byte, bestBlock uint32) (*ticketvote.
 		// Some other error
 		return nil, fmt.Errorf("summaryCache: %v", err)
 	default:
-		// Caches summary was found. Return it.
+		// Cached summary was found. Update the best block and return it.
+		s.BestBlock = bestBlock
 		return s, nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -2400,7 +2400,8 @@ func (p ticketVotePlugin) summary(token []byte, bestBlock uint32) (ticketvote.`
`2400`	`2400`	`// Some other error`
`2401`	`2401`	`return nil, fmt.Errorf("summaryCache: %v", err)`
`2402`	`2402`	`default:`
`2403`		`- // Caches summary was found. Return it.`
	`2403`	`+ // Cached summary was found. Update the best block and return it.`
	`2404`	`+ s.BestBlock = bestBlock`
`2404`	`2405`	`return s, nil`
`2405`	`2406`	`}`
`2406`	`2407`