Skip to content
This repository has been archived by the owner on Nov 3, 2022. It is now read-only.

Decouple assessment handling from map layout calculation #830

Closed
bonndan opened this issue Dec 23, 2021 · 0 comments · Fixed by #833
Closed

Decouple assessment handling from map layout calculation #830

bonndan opened this issue Dec 23, 2021 · 0 comments · Fixed by #833
Labels
cleanup java Pull requests that update Java code javascript Pull requests that update Javascript code L T-Shirt size for estimation.

Comments

@bonndan
Copy link
Collaborator

bonndan commented Dec 23, 2021

In order to provide more dynamic map as described in #805 and #576 it is necessary to decouple graph rendering from status rendering. If the frontend can set status on map components the number of map reloads will also be decreased.

  • after indexing, calculate if the map layout really changes and the LayoutChangedEvent needs to be triggered
  • reload map in FE only on LayoutChangedEvent
  • start assessment calculation on ProcessingFinishedEvent and only trigger AssessmentChangedEvent if it has really changed
  • repaint map item status in FE on AssessmentChangedEvent
@bonndan bonndan added cleanup java Pull requests that update Java code javascript Pull requests that update Javascript code L T-Shirt size for estimation. labels Dec 23, 2021
bonndan pushed a commit that referenced this issue Dec 23, 2021
[#830] assessment changes with diff
631c9ed
bonndan pushed a commit that referenced this issue Dec 23, 2021
[#830] layout changes event only triggered on create, delete
05a0a69
bonndan pushed a commit that referenced this issue Dec 24, 2021
[#830] introduced hex code from other gujuno lib, change radius calcu…
cb81286 
…lation
bonndan pushed a commit that referenced this issue Dec 25, 2021
[#830] wip
7842e07
bonndan pushed a commit that referenced this issue Dec 27, 2021
[#830] map state via css
11f0294
bonndan pushed a commit that referenced this issue Dec 27, 2021
[#830] cleanup
44c39e7
bonndan pushed a commit that referenced this issue Dec 27, 2021
[#830] cleanup, assessment data not propagated through event
43cd96f
bonndan pushed a commit that referenced this issue Dec 27, 2021
[#830] skipping changes without message
4bbf54a
bonndan pushed a commit that referenced this issue Dec 27, 2021
[#830] hiding disabled kpis
e1eb462
bonndan pushed a commit that referenced this issue Dec 27, 2021
[#830] cleanup
c290962
bonndan pushed a commit that referenced this issue Dec 27, 2021
[#830] changelog propagation fix
5a54bbb
bonndan pushed a commit that referenced this issue Dec 27, 2021
[#830] cleanup
ec21144
bonndan pushed a commit that referenced this issue Dec 27, 2021
[#830] displaying assessment changes
7afea08
bonndan pushed a commit that referenced this issue Dec 27, 2021
[#830] cleanup
4b2172f
bonndan pushed a commit that referenced this issue Dec 27, 2021
[#830] cleanup
1db92de
bonndan pushed a commit that referenced this issue Dec 27, 2021
[#830] cleanup: deleted flaky integration test which depends on exter…
168e30f 
…nal network
bonndan pushed a commit that referenced this issue Dec 27, 2021
[#830] cleanup
7be81a9
bonndan pushed a commit that referenced this issue Dec 27, 2021
[#830] cleanup
7e25d7c
@bonndan bonndan mentioned this issue Dec 28, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cleanup java Pull requests that update Java code javascript Pull requests that update Javascript code L T-Shirt size for estimation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

830 decouple dedica-team/nivio
1 participant
@bonndan