Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can‘t use china id #34

Open
ttjim opened this issue Jun 29, 2023 · 5 comments
Open

Can‘t use china id #34

ttjim opened this issue Jun 29, 2023 · 5 comments

Comments

@ttjim
Copy link

ttjim commented Jun 29, 2023

It can‘t be used on the apple china id, and the login is restricted.

@dedoussis
Copy link
Owner

Hi @ttjim! Thanks for reporting this issue! Could you provide some more detail on the error you see? Some screenshot as well as some logs from the dev console of the extension pop-up would really help.

@ttjim
Copy link
Author

ttjim commented Jun 30, 2023

I use US id, it's ok. but china id show "Failed to sign in. Please try again." the icloud accounts in China and the US are in different locations.

@ttjim
Copy link
Author

ttjim commented Jul 2, 2023

Authentication failed because China mainland account migated to icloud.com.cn instead of icloud.com.

class ICloudClient {
private static readonly DEFAULT_BASE_URL_CONFIG = {
auth: 'https://idmsa.apple.com/appleauth/auth',
home: 'https://www.icloud.com',
setup: 'https://setup.icloud.com/setup/ws/1',
};

@gutenye
Copy link
Contributor

gutenye commented Jan 18, 2024

@ttjim Checkout #47

@dedoussis
Copy link
Owner

Have merged the code change related to this! Many thanks to @gutenye for the initial implementation and for e2e testing the changes.

Published version 1.2.5 to both the Chrome and Firefox stores. Let me know how it works @ttjim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants