Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore shelve for connected components dict #966

Closed
NickCrews opened this issue Feb 21, 2022 · 2 comments
Closed

Explore shelve for connected components dict #966

NickCrews opened this issue Feb 21, 2022 · 2 comments

Comments

@NickCrews
Copy link
Contributor

If the connected components dict in clustering.union_find() is running us out of memory, maybe we can use https://docs.python.org/3/library/shelve.html as a disk-based dictionary?

@fgregg
Copy link
Contributor

fgregg commented Feb 21, 2022

i think it's worth a look, but when we looked at shelve before for other purposes in the library it was surprisingly slow.

@NickCrews
Copy link
Contributor Author

Good to know. I'd say reopen if we add profiling as in #967 and see that this actually is a bottleneck.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants