Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to use the same internal api for cli and interactive interface #79

Open
l-wegner opened this issue Oct 18, 2023 · 5 comments
Assignees

Comments

@l-wegner
Copy link

Is your feature request related to a problem? Please describe.
Currently there are function, which are available in cli and some are available in interactive interface. Adding new functionality is quite distributed.

Describe the solution you'd like
Having an internal API, which encapsulates the player, the recording, the favs, and the stations db, would allow cleaning up the main.py regarding the parsed arguments and allows for implementing a better interactive interface.
Further more extract the ui printing.

In the best case the utilities.py is almost empty afterwards.

Additional context
Add any other context or screenshots about the feature request here.

@github-actions
Copy link

Hi, @l-wegner,
Thanks for your contribution 💙 .
Contributors 🧑‍🤝‍🧑 like you make the open source community 🌍 such an amazing place to learn 📖 , inspire 👼, and create 🎨 .
We will investigate 👀 and get back to you as soon as possible 👍 . Just make sure you have given us sufficient information ℹ️.

By that time enjoy this meme 👇 , hope you like it 😄

meme

Use this action on your projects. Use jokes on issues instead.

@l-wegner
Copy link
Author

I'll start this tomorrow.

Repository owner deleted a comment from create-issue-branch bot Oct 19, 2023
@deep5050
Copy link
Owner

yes, I also feel that. need to refactor before I add new features. we can discuss the design

@umop3plsdn
Copy link

omg this would be amazing or even the ability to use socat to listen in to the dumped json so we can integrate into other apps like current song or station info

@deep5050
Copy link
Owner

deep5050 commented Nov 5, 2023

omg this would be amazing or even the ability to use socat to listen in to the dumped json so we can integrate into other apps like current song or station info

did not get it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants