Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 wheels #314

Closed
pbregener opened this issue Nov 23, 2023 · 4 comments · Fixed by #316
Closed

Python 3.12 wheels #314

pbregener opened this issue Nov 23, 2023 · 4 comments · Fixed by #316
Assignees

Comments

@pbregener
Copy link
Contributor

It seems like the latest version builds and works fine with Python 3.12 as well! Just built it in a clean Python 3.12 container and all tests pass:

pytest output
============================================= test session starts =============================================
platform linux -- Python 3.12.0, pytest-7.4.3, pluggy-1.3.0 -- /usr/local/bin/python
cachedir: .pytest_cache
rootdir: /root/ruptures
configfile: pyproject.toml
testpaths: tests
collected 585 items

tests/test_bnode.py::test_bnode PASSED                                                                  [  0%]

[ ... ALL TESTS ARE PASSING ... ]

tests/test_metrics.py::test_exception[randindex] PASSED                                                 [100%]

============================================== warnings summary ===============================================tests/test_costs.py: 5 warnings
tests/test_detection.py: 21 warnings
  /root/ruptures/src/ruptures/costs/costnormal.py:27: UserWarning: New behaviour in v1.1.5: a small bias is added to the covariance matrix to cope with truly constant segments (see PR#198).
    warnings.warn(

tests/test_display.py::test_display_with_options
  /usr/local/lib/python3.12/site-packages/dateutil/tz/tz.py:37: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
    EPOCH = datetime.datetime.utcfromtimestamp(0)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
====================================== 585 passed, 27 warnings in 3.74s =======================================

There are some of the "usual" Python 3.12-related timezone-awareness deprecation warnings that you can see pop up in all kinds of Python packages these days, but nothing critical.

Are there any plans for providing Python 3.12 wheels?
Kindly pinging @oboulant as you were extremely helpful with Python 3.11 wheels not too long ago :)

@oboulant oboulant self-assigned this Nov 23, 2023
@oboulant
Copy link
Collaborator

Hi @pbregener

Thx for the ping ! I will have a look at that (most probably next week) !

@tg12
Copy link

tg12 commented Nov 23, 2023

Nice

@oboulant
Copy link
Collaborator

oboulant commented Dec 8, 2023

PR #316 merged !
I will perform the release early on next week (out of the office today) !

@oboulant
Copy link
Collaborator

v1.1.9 is out !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants