Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpdatePerformanceTracker can miss short lived entries #4705

Open
cpwright opened this issue Oct 24, 2023 · 0 comments
Open

UpdatePerformanceTracker can miss short lived entries #4705

cpwright opened this issue Oct 24, 2023 · 0 comments
Assignees
@rcaudy
Labels
bug Something isn't working core Core development tasks query engine
Milestone
Backlog

Comments

@cpwright
Copy link
Contributor

Description

The UpdatePerformanceTracker only maintains a weak reference to the PerformanceEntry objects. If a table is garbage collected before the end of the cycle, then the PerformanceEntry may also be garbage collected. The UpdatePerformance will then be unable to log the time taken by that entry.

Expected results

The garbage collected table's entry will survive until the next UpdatePerformanceTracker flush.

Versions

  • Deephaven: 0.29.1
@cpwright cpwright added bug Something isn't working triage labels Oct 24, 2023
@rcaudy rcaudy added this to the Backlog milestone Oct 24, 2023
@rcaudy rcaudy added query engine core Core development tasks and removed triage labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcaudy rcaudy

Labels
bug Something isn't working core Core development tasks query engine
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@rcaudy @cpwright