Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build process for jars that depend on JVM internals #6345

Open
devinrsmith opened this issue Nov 8, 2024 · 0 comments
Open

Improve build process for jars that depend on JVM internals #6345

devinrsmith opened this issue Nov 8, 2024 · 0 comments
Assignees
Labels
build feature request New feature or request
Milestone

Comments

@devinrsmith
Copy link
Member

As part of #6340, we specifically work around javac safety procedures by downgrading from --release to --source and --target due to the additional safety the former imposes:

Note: When using --release to specify a release that supports the Java Platform Module System, the --add-exports option cannot be used to enlarge the set of packages exported by the Java SE, JDK, and standard modules in the specified release.

This allows us to continue to add exports of JVM modules. It is on us to verify that these exports are still valid across the range of JVMs we claim to support.

I more thorough solution would be to build a JAR per JVM we intend to support and potentially combine them all into a multi-jar.

Right now, this effects two modules - clock-impl and hotspot-impl.

@devinrsmith devinrsmith added feature request New feature or request build labels Nov 8, 2024
@devinrsmith devinrsmith added this to the Backlog milestone Nov 8, 2024
@devinrsmith devinrsmith self-assigned this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant