Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flight SQL filter pattern improvements #6403

Open
devinrsmith opened this issue Nov 20, 2024 · 0 comments
Open

Flight SQL filter pattern improvements #6403

devinrsmith opened this issue Nov 20, 2024 · 0 comments
Assignees
@devinrsmith
Labels
feature request New feature or request sql
Milestone
Backlog

Comments

@devinrsmith
Copy link
Member

devinrsmith commented Nov 20, 2024 •
edited
Loading

The Flight SQL filter pattern spec leaves a lot to be desired. That is, there does not seem to be any potential for escaping. In particular, the _ (which is pretty common in DH table names) can't be matched literally, at least according to the current specification: https://github.com/apache/arrow/blob/apache-arrow-18.0.0/format/FlightSql.proto#L1179-L1186. This may be something we want to raise with the Arrow project.

We may also want to increase our testing of Unicode filter patterns.
@devinrsmith devinrsmith added feature request New feature or request sql labels Nov 20, 2024
@devinrsmith devinrsmith added this to the Backlog milestone Nov 20, 2024
@devinrsmith devinrsmith self-assigned this Nov 20, 2024
devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Nov 20, 2024
@devinrsmith
Review response
490c236 
Add link to deephaven#6403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devinrsmith devinrsmith

Labels
feature request New feature or request sql
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@devinrsmith