From ed4ee40982b703063445f05ae0c634c7ffa425e6 Mon Sep 17 00:00:00 2001 From: Devin Smith Date: Mon, 28 Oct 2024 11:10:35 -0700 Subject: [PATCH 1/2] Add Java 23 tests --- buildSrc/src/main/groovy/io/deephaven/csv/Constants.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/buildSrc/src/main/groovy/io/deephaven/csv/Constants.groovy b/buildSrc/src/main/groovy/io/deephaven/csv/Constants.groovy index 7cf50033..b85c6545 100644 --- a/buildSrc/src/main/groovy/io/deephaven/csv/Constants.groovy +++ b/buildSrc/src/main/groovy/io/deephaven/csv/Constants.groovy @@ -3,5 +3,5 @@ package io.deephaven.csv class Constants { public static int LATEST_LTS = 21 - public static int[] TEST_VERSIONS = [8, 11, 17, 21] + public static int[] TEST_VERSIONS = [8, 11, 17, 21, 23] } From 1f7a315b0aa69ed9cbdf3884cd677fc2ab9e4f1f Mon Sep 17 00:00:00 2001 From: Devin Smith Date: Mon, 28 Oct 2024 11:12:56 -0700 Subject: [PATCH 2/2] Ensure 23 is installed --- .github/workflows/check.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index c3d5bb7b..8ea6b4bf 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -51,6 +51,14 @@ jobs: java-version: '21' cache: 'gradle' + - name: Setup JDK 23 + id: setup-java-23 + uses: actions/setup-java@v4 + with: + distribution: 'temurin' + java-version: '23' + cache: 'gradle' + - name: Set JAVA_HOME run: echo "JAVA_HOME=${{ steps.setup-java-21.outputs.path }}" >> $GITHUB_ENV @@ -58,7 +66,7 @@ jobs: run: | cat .github/env/${{ runner.os }}/gradle.properties >> gradle.properties echo >> gradle.properties - echo "org.gradle.java.installations.paths=${{ steps.setup-java-8.outputs.path }},${{ steps.setup-java-11.outputs.path }},${{ steps.setup-java-17.outputs.path }},${{ steps.setup-java-21.outputs.path }}" >> gradle.properties + echo "org.gradle.java.installations.paths=${{ steps.setup-java-8.outputs.path }},${{ steps.setup-java-11.outputs.path }},${{ steps.setup-java-17.outputs.path }},${{ steps.setup-java-21.outputs.path }},${{ steps.setup-java-23.outputs.path }}" >> gradle.properties echo "customDoubleParser=${{ matrix.customDoubleParser }}" >> gradle.properties cat gradle.properties