Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New file creation never ends up in a good spot #48

Open
chipkent opened this issue Jul 16, 2024 · 3 comments
Open

New file creation never ends up in a good spot #48

chipkent opened this issue Jul 16, 2024 · 3 comments
Labels
bug Something isn't working question Further information is requested
Milestone

Comments

@chipkent
Copy link
Member

Plugin: 1.3.0 pre

  1. run some DH code that produces tables or plots
  2. create a new code file

The code file always ends up in the DH figure tab group and not with any other code. This feels clunky.

image
@chipkent chipkent added bug Something isn't working triage labels Jul 16, 2024
@vbabich
Copy link

vbabich commented Jul 24, 2024

@bmingles is there a way to define tab groups in VSCode?

@vbabich vbabich added the question Further information is requested label Jul 24, 2024
@bmingles
Copy link
Collaborator

bmingles commented Jul 30, 2024

@vbabich The only apis I'm aware of allow setting the viewColumn. This is a number which seems to create new tab groups if the number is > than the number of existing groups. The caveat here is that new groups always get added as columns. There is no way to target rows. Once they exist, things can be moved around, and they will stay in place when panels update.

All that said, I think this particular issue is caused by our panels stealing focus, and the active tab group is where new files are created. We could explore resetting the focus to the same tab group as the editor initiating dh commands or something like that, but it's tricky since it's hard to differentiate when our panel steals focus on load vs the user explicitly selecting an editor in a tab group. Our panels can be dragged into the same tab group as an editor, so it's possible the user wants a particular group to have focus in which case we'd not want to change it. Probably ways to improve this, but we'll need to think through the edge cases.

@vbabich vbabich added this to the Backlog milestone Jul 30, 2024
@vbabich vbabich removed the triage label Jul 30, 2024
@chipkent
Copy link
Member Author

This problem is worse than just new files. Any time a file is opened, it seems to end up in the "plots and tables" group. This results in a bunch of clicking and moving to organize it to an ok spot. Not a great workflow for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants