-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
selectedRanges
for TablePlugins do not update when selection is changed
#2274
Comments
@ilyaberdnikov I've opened a PR to fix the issue with panel not being passed through: #2308 |
mofojed
added a commit
that referenced
this issue
Dec 9, 2024
- Deprecated props were not being passed through at all to the plugins - We need to continue to pass through the deprecated props until we have a replacement - Partial #2274
mofojed
added a commit
to mofojed/web-client-ui
that referenced
this issue
Dec 10, 2024
- Deprecated props were not being passed through at all to the plugins - We need to continue to pass through the deprecated props until we have a replacement - Partial deephaven#2274
mofojed
added a commit
that referenced
this issue
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
If you create a TablePlugin that listens to
selectedRange
, it does not update reactively and is just[]
. Also,panel
is no longer passed through. See https://github.com/deephaven/web-client-ui/pull/2181/files which added these props back, but didn't addpanel
back.By just passing through
this.irisGrid.current?.state.selectedRanges
, it's not re-rendering the plugin when the selected ranges is actually changed:web-client-ui/packages/dashboard-core-plugins/src/panels/IrisGridPanel.tsx
Line 442 in b552282
The text was updated successfully, but these errors were encountered: