Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectedRanges for TablePlugins do not update when selection is changed #2274

Open
mofojed opened this issue Oct 29, 2024 · 2 comments
Open
Labels
bug Something isn't working
Milestone

Comments

@mofojed
Copy link
Member

mofojed commented Oct 29, 2024

Description

If you create a TablePlugin that listens to selectedRange, it does not update reactively and is just []. Also, panel is no longer passed through. See https://github.com/deephaven/web-client-ui/pull/2181/files which added these props back, but didn't add panel back.
By just passing through this.irisGrid.current?.state.selectedRanges, it's not re-rendering the plugin when the selected ranges is actually changed:

selectedRanges={this.irisGrid.current?.state.selectedRanges}

@mofojed mofojed added bug Something isn't working triage Issue requires triage labels Oct 29, 2024
@vbabich vbabich added this to the Backlog milestone Nov 5, 2024
@vbabich vbabich removed the triage Issue requires triage label Nov 5, 2024
@ilyaberdnikov
Copy link

@mofojed @vbabich It's blocking us from upgrading to DH 0.37? do you have any guidance here, either on timelines or on proposed implementation?

@mofojed
Copy link
Member Author

mofojed commented Dec 9, 2024

@ilyaberdnikov I've opened a PR to fix the issue with panel not being passed through: #2308
For selectedRanges not updating, we'll be baking that functionality into ui.table soon: deephaven/deephaven-plugins#822
I'll see if we can also hotfix it for these table plugins to update correctly. I don't believe it was a regression of existing behaviour.

mofojed added a commit that referenced this issue Dec 9, 2024
- Deprecated props were not being passed through at all to the plugins
- We need to continue to pass through the deprecated props until we have
a replacement
- Partial #2274
mofojed added a commit to mofojed/web-client-ui that referenced this issue Dec 10, 2024
- Deprecated props were not being passed through at all to the plugins
- We need to continue to pass through the deprecated props until we have
a replacement
- Partial deephaven#2274
mofojed added a commit that referenced this issue Dec 10, 2024
- Deprecated props were not being passed through at all to the plugins
- We need to continue to pass through the deprecated props until we have
a replacement
- Partial #2274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants