Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-redux to v8 #2290

Open
mofojed opened this issue Nov 12, 2024 · 1 comment
Open

Update react-redux to v8 #2290

mofojed opened this issue Nov 12, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mofojed
Copy link
Member

mofojed commented Nov 12, 2024

Migration instructions here: https://github.com/reduxjs/react-redux/releases/tag/v8.0.0

Might be as easy as just bumping the version number.

Note that upgrading to v9 would be a breaking change and require quite a bit of work.

@mofojed mofojed added enhancement New feature or request triage Issue requires triage labels Nov 12, 2024
@vbabich vbabich added this to the November 2024 milestone Nov 12, 2024
@vbabich vbabich removed the triage Issue requires triage label Nov 12, 2024
@mofojed
Copy link
Member Author

mofojed commented Nov 13, 2024

Seems it's not just as easy as bumping version number. Some of the errors encountered:

...
packages/code-studio/src/settings/FormattingSectionContent.tsx:658:4 - error TS2345: Argument of type 'typeof FormattingSectionContent' is not assignable to parameter of type 'ComponentType<never>'.
  Type 'typeof FormattingSectionContent' is not assignable to type 'ComponentClass<never, any>'.
    Types of property 'defaultProps' are incompatible.
      Type '{ scrollTo: () => void; }' is not assignable to type 'undefined'.

658 })(FormattingSectionContent);
       ~~~~~~~~~~~~~~~~~~~~~~~~

packages/code-studio/src/settings/SettingsMenu.tsx:252:14 - error TS2322: Type '{}' is not assignable to type 'never'.

252             <FormattingSectionContent />
                 ~~~~~~~~~~~~~~~~~~~~~~~~

packages/code-studio/src/settings/ThemeSectionContent.tsx:28:16 - error TS2345: Argument of type 'ThunkAction<Promise<CustomizableWorkspace>, RootState, never, PayloadAction<unknown>>' is not assignable to parameter of type 'AnyAction'.

28       dispatch(updateSettings({ gridDensity: density }));
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

packages/code-studio/src/styleguide/StyleGuideInit.tsx:55:4 - error TS2345: Argument of type 'typeof StyleGuideInit' is not assignable to parameter of type 'ComponentType<never>'.
  Type 'typeof StyleGuideInit' is not assignable to type 'FunctionComponent<never>'.
    Types of property 'propTypes' are incompatible.
      Type '{ workspace: PropTypes.Requireable<PropTypes.InferProps<{}>>; setWorkspace: PropTypes.Validator<(...args: any[]) => any>; }' is not assignable to type 'undefined'.

55 })(StyleGuideInit);
      ~~~~~~~~~~~~~~
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants