-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deepin: Use BFQ as the elevator for SQ rotate devices #421
base: linux-6.6.y
Are you sure you want to change the base?
Conversation
For hdd optimize. Question: 1.How to test QUEUE_FLAG_NONROT? 2.It is correct time to get the flag?? 3.If we can get the flag,so we can only use BFQ elevator for hdd. Link:zen-kernel/zen-kernel@c614dbb
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
这个修改道理上来说应该系统来改,系统侧拿到了/sys/block/sd{X}/queue/rotational的值可以判断是否是机械盘,如果是0就是非机械盘,是1就是机械盘然后做这个修改。 |
这个方案初步看是可行的,blk_queue_flag_set(QUEUE_FLAG_NONROT在下面调用流程之前被设置,所以这样判断是可行的。 |
Why: bfq elevator shows high bandwidth in read/write than other in hdd.[1] Question: It is correct time to get the flag? If we can get the flag,so we can only use BFQ elevator for hdd. or it is same as before. Answer: It is ok for: use this macro:blk_queue_flag_set(QUEUE_FLAG_NONROT for no rotate block device like ssd: blk_queue_flag_set(QUEUE_FLAG_NONROT device_add_disk-> elevator_init_mq-> elevator_get_default-> choose mq-deadline for rotate device like hdd: device_add_disk-> elevator_init_mq-> elevator_get_default-> choose bfq Link:https://ieeexplore.ieee.org/document/7469567 [1] Signed-off-by: Wentao Guan <[email protected]>
ca29f8d
to
ad0a462
Compare
deepin pr auto review关键摘要:
是否建议立即修改:
|
|
实际的优化效果需要测试数据报告留档 |
建议将相关改动改为修改udev实现 |
For hdd optimize.
Question:
1.How to test QUEUE_FLAG_NONROT?
2.It is correct time to get the flag??
3.If we can get the flag,so we can only use BFQ elevator for hdd.
Link:zen-kernel/zen-kernel@c614dbb