Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BeiZhongWangXin] [Deepin Kernel SIG] eth: bzwx: ne6x_vf: break when ETH_SS_TEST #497

Merged

Conversation

Avenger-285714
Copy link
Collaborator

Fix follow error with clang-19:

drivers/net/ethernet/bzwx/nce/ne6x_vf/ne6xvf_ethtool.c:211:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
211 | default:
| ^
drivers/net/ethernet/bzwx/nce/ne6x_vf/ne6xvf_ethtool.c:211:2: note: insert 'break;' to avoid fall-through
211 | default:
| ^
| break;
1 error generated.

Fix follow error with clang-19:

drivers/net/ethernet/bzwx/nce/ne6x_vf/ne6xvf_ethtool.c:211:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
  211 |         default:
      |         ^
drivers/net/ethernet/bzwx/nce/ne6x_vf/ne6xvf_ethtool.c:211:2: note: insert 'break;' to avoid fall-through
  211 |         default:
      |         ^
      |         break;
1 error generated.

Signed-off-by: WangYuli <[email protected]>
@Avenger-285714 Avenger-285714 merged commit a42b050 into deepin-community:linux-6.6.y Nov 25, 2024
3 of 4 checks passed
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • ne6xvf_get_strings函数中,新增的break语句在ETH_SS_TEST分支后是多余的,因为ETH_SS_TEST分支已经包含了break语句。

是否建议立即修改:

  • 是,建议立即移除多余的break语句,以保持代码的简洁性和一致性。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from avenger-285714. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants