Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_retries and timeout params to all AzureOpenAI classes #7945

Open
EdoardoAbatiTR opened this issue Jun 27, 2024 · 3 comments
Open

Add max_retries and timeout params to all AzureOpenAI classes #7945

EdoardoAbatiTR opened this issue Jun 27, 2024 · 3 comments
Labels
Contributions wanted! Looking for external contributions good first issue Good for newcomers type:feature New feature or request

Comments

@EdoardoAbatiTR
Copy link

Is your feature request related to a problem? Please describe.

Currently all OpenAI related classes (e.g. OpenAIDocumentEmbedder, OpenAIChatGenerator) can be initialised by setting max_retries and timeout params.

The corresponding AzureOpenAI don't always have the same params.

Describe the solution you'd like

It would be nice to have these params in the AzureOpenAI classes

Describe alternatives you've considered

Subclass AzureOpenAI and create custom components.

Additional context

cc @anakin87 :)

@anakin87 anakin87 added type:feature New feature or request Contributions wanted! Looking for external contributions good first issue Good for newcomers labels Jun 27, 2024
@anakin87
Copy link
Member

Thanks @EdoardoAbatiTR!

I'm also opening this for contributions. In case anyone is interested, let's discuss it here.

@nvzard
Copy link

nvzard commented Jul 4, 2024

Hey,

I am new here. Can I assign this to myself?

@anakin87
Copy link
Member

anakin87 commented Jul 4, 2024

@nvzard feel free to work on this. Take a look at the guidelines for contributors.

I would suggest creating one PR for each component to be changed.
E.g., start with AzureOpenAIGenerator and use OpenAIGenerator as an inspiration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributions wanted! Looking for external contributions good first issue Good for newcomers type:feature New feature or request
Projects
Development

No branches or pull requests

3 participants