Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize plotting colors with flexibility to change #30

Open
beckynevin opened this issue Mar 6, 2024 · 11 comments
Open

Standardize plotting colors with flexibility to change #30

beckynevin opened this issue Mar 6, 2024 · 11 comments
Assignees
Labels
question Further information is requested

Comments

@beckynevin
Copy link
Collaborator

This might include other **kwargs

@jsv1206 jsv1206 changed the title Standardize plotting colors Standardize plotting colors with flexibility to change Mar 6, 2024
@bnord
Copy link
Contributor

bnord commented Mar 25, 2024

reminder: use color-blindness-friendly palettes.

@bnord
Copy link
Contributor

bnord commented Mar 25, 2024

It might be worth starting with JasonPoh's color and linestyle choices.

@voetberg
Copy link
Contributor

voetberg commented May 17, 2024

Right now theses are the defaults as far as colors and linestyles go.

        "axis_spines": False, 
        "tight_layout": True,
        "default_colorway": "viridis", 
        "plot_style": "fast", 
        "parameter_labels" : ['$m$','$b$'], 
        "parameter_colors": ['#9C92A3','#0F5257'], 
        "line_style_cycle": ["-", "-."],
        "figure_size": [6, 6]

Which I believe were taken from JasonPoh's defaults, and I know viridis is supposed to be friendly.

@bnord
Copy link
Contributor

bnord commented Jun 5, 2024

@voetberg are these set in the main input config yaml file?

@voetberg
Copy link
Contributor

voetberg commented Jun 5, 2024

@bnord - sure are. There are a set of defaults (utils/defaults.py) but otherwise they can set per plot or per-run in the config.

@bnord
Copy link
Contributor

bnord commented Jun 5, 2024

sorry, I'm silly. I couldn't find the config file.

@bnord
Copy link
Contributor

bnord commented Jun 5, 2024

where is it?

@voetberg
Copy link
Contributor

voetberg commented Jun 5, 2024

There's no general config file - it's always supplied by the user when running. Defaults has the same fields though. Closest to a config that exists at a moment is generated on the fly during testing here:

def config_factory():

Which is used here:
input_yaml = {

Descriptions and documentation for each one of those fields is still in progress until there's a defined list of plots and metrics

@bnord
Copy link
Contributor

bnord commented Jun 5, 2024

I was thinking that we'd do a config file input so that users didn't have to edit code AND so that they weren't relegated to long CLI strings.

@voetberg
Copy link
Contributor

voetberg commented Jun 6, 2024

Sorry I think I'm explaining this poorly. They can use a config file (using the --config flag), and they don't need to edit code. There just isn't a supplied config template yet because not all the metrics/plots we want to use are in place. Once that's completely done, we can brainstorm what fields we want them to modify and what plots/metrics to show off in the template.

@bnord
Copy link
Contributor

bnord commented Jun 6, 2024

oh, sorry. I get it. thanks.

@voetberg voetberg added question Further information is requested and removed To do labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants