Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do typing for all external functions #6

Closed
beckynevin opened this issue Jan 29, 2024 · 2 comments
Closed

Do typing for all external functions #6

beckynevin opened this issue Jan 29, 2024 · 2 comments
Assignees
@voetberg
Labels
documentation Improvements or additions to documentation in progress

Comments

@beckynevin
Copy link
Collaborator

See here for example: https://github.com/sbi-dev/sbi/blob/main/sbi/analysis/plot.py
@bnord bnord added the documentation Improvements or additions to documentation label Jun 5, 2024
@bnord
Copy link
Contributor

bnord commented Jun 5, 2024

@beckynevin @voetberg
Is this redundant with #46, #47, #48

@voetberg
Copy link
Contributor

voetberg commented Jun 6, 2024

The typing is different - We can just massage this issue out of overlap

@voetberg voetberg changed the title Need to do typing and docstrings for all functions Do typing for all external functions Jun 6, 2024
@voetberg voetberg self-assigned this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@voetberg voetberg

Labels
documentation Improvements or additions to documentation in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bnord @beckynevin @voetberg