Goals before ML-IAP/CCA-2023 [DEADLINE 11/22]

[evavagiakis]

• Update code and tests after Sam's class hygiene
• Fix any broken tests
• Sam to fix any broken lines in notebook
• Sam to make sure all documentation is updated to respect new argument ordering
• Eve to review notebooks and push changes after Sam's review
• Eve to check outputs in notebooks/diagnose any physics concerns
• Sam to look into coverage and decide how to deal with that
• Merge code to main
• Clean up other branches and establish dev branch for future work
• Eve to clean up issues
• Finalize repo name (DeepSZSim?)
• Ensure naming convention consistent within code (pip install)
• Ensure naming convention consistent in notebooks
• Add ReadMe
• Eve to write 3 min flash talk slides and circulate for review before 11/20
• Sam/ @bnord to review flash talk for upload by 11/22
• Eve to edit module-level docstrings to remove name of file in each file

[evavagiakis]

Changes I have made 11/18/2023:

• demo_full_pipeline and dm_halo_dist.py:
  • M_200 throughout. We still had M_vir and M_500 different places. We are going with M_200 everywhere, right? Left to do: check for any other M_vir,500 in other python scripts.
  • Changed sign from total_map=conv_map - noise_map to total_map=conv_map + noise_map
• Added module-level doc strings

Open questions:

• Why is y_map.max() a different value than y[0]?
• AP commonly returns positive dT and is strongly dependent on noise; I feel like this shouldn't be the case for this mass of cluster. I suppose depends on noise level and CMB. Should we include AP at this stage?
• What is the difference between simulate_clusters and simulate_T_submaps and what do we want to demo in the notebooks?
• Can we make any updates to tests after my changes?