Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test to check Battaglia profile against NFW profile #68

Closed
evavagiakis opened this issue Jun 19, 2023 · 2 comments
Closed

Unit test to check Battaglia profile against NFW profile #68

evavagiakis opened this issue Jun 19, 2023 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@evavagiakis
Copy link
Collaborator

@kbanker to work on unit test which checks the residuals from portion of Battaglia profile against NFW profile from existing function such as https://docs.astropy.org/en/stable/api/astropy.modeling.physical_models.NFW.html and ensures they are within (5-10?)%. We can determine the number together after plotting some examples and reviewing https://arxiv.org/pdf/1109.3711.pdf

@bnord
Copy link
Contributor

bnord commented Jun 19, 2023

some guidance for writing unit tests:
https://lsstdesc.org/pages/DESchool.html#MikeJarvis

@bnord bnord added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 19, 2023
@bnord bnord added this to the alpha release milestone Jun 19, 2023
@evavagiakis
Copy link
Collaborator Author

This unit test is stale and we will need to decide on new unit tests for our initial release. I'm closing the issue and have added a new one here #152 which describes adding a function to plot an NFW profile but decouples it from any unit test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants