Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domino + PP #950

Open
XZQshiyu opened this issue Jan 9, 2025 · 0 comments
Open

Domino + PP #950

XZQshiyu opened this issue Jan 9, 2025 · 0 comments

Comments

@XZQshiyu
Copy link

XZQshiyu commented Jan 9, 2025

I’m excited about the recent introduction of Domino and its impressive TP optimization.
When I was using deepspeed-domino to better overlap comm & comp in TP, I found domino use forward_backward_no_pipelining() in schedules.py. Is that mean I couldn't use domino(tp optimization) and pp together?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@XZQshiyu