Skip to content
This repository has been archived by the owner on Apr 6, 2021. It is now read-only.

Would love some information about the android/ios integration, to work on the code #147

Open
gioragutt opened this issue Sep 30, 2020 · 1 comment

Comments

@gioragutt
Copy link

We use deepstream, and the JS part is fine. The java part is very problematic and might be replaced if problems are not fixed.

You can see that I have a fork of the repo, where I just sweeped the entire codebase and cleaned it up, following standards in our company, which are of course subject to review.

One this I had to do is raise sourceCompatibility and targetCompatibility to 1.8 from 1.6.

I'm sure this has something to do with Android support, but I wonder how much, and if it is not reasonable to take that step.
Also, there's this whole j2ios conversions, which I have absolutely no knowledge about, so any help regarding it would be great, if the changes I do should ever have a chance to be merged.

@yasserf I saw your name in the code and that you commented in the repo, so maybe you could help with this?

It's a shame to let this great project die 🤷🏻‍♂️

@yasserf
Copy link
Contributor

yasserf commented Oct 7, 2020

hello @gioragutt

Thank you for raising this.

So raising source compat is fine, it was 1.6 to support enterprise customers before, but Java 1.6 is pretty outdated by now.

We can also ignore the j2objc part, that is only adopted by a couple of people and is not worth blocking the java codebase.

Generally there was meant to be a new kotlin based codebase that works on native (which means we would have an ios and C++ as well, even if not as amazing as multiple SDKs via native).

I'm happy to give you access to deepstreamIO to push your changes to master if you would like.

Generally the code needs a refactor to work with v4.0 onwards due to protocol switch (v3 and back had a text based protocol which logic was leaked through the entire code).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants