Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default uds-core to JSON Logging Format #1042

Open
jamestexas opened this issue Nov 22, 2024 · 0 comments
Open

Default uds-core to JSON Logging Format #1042

jamestexas opened this issue Nov 22, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jamestexas
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, uds-core defaults to text-based access logs, which are harder to parse and less compatible with modern logging aggregation tools. This makes debugging and integrating with tools like Fluentd, Elastic Stack, and k9s more cumbersome. Switching to JSON as the default log format would address these challenges.

Additionally, the upcoming Ambient Mode may impact or require adjustments to this configuration, so the scope of this request is focused on sidecar deployments for now.

Describe the solution you'd like

  • Given an uds-core deployment with sidecars,
  • When the access logging configuration defaults to JSON format,
  • Then users can benefit from structured, easy-to-parse logs, simplifying integration with logging tools and improving developer experience.

Describe alternatives you've considered

  • Keeping text-based logs as the default while providing clearer documentation on enabling JSON logging through Telemetry API or MeshConfig.
  • Making JSON logging an optional configuration for users to enable explicitly instead of setting it as the default.
  • Investigating Ambient Mode logging configurations upfront to ensure a unified approach across both sidecar and Ambient deployments.

Additional context

  • Related Istio documentation: Istio Envoy Access Logs.
  • Switching to JSON logging as the default could also enhance compatibility with third-party tools and reduce issues caused by custom log formats.
  • Testing is needed to validate behavior in both current sidecar deployments and the potential impact on Ambient Mode logging in the future.
@jamestexas jamestexas added the enhancement New feature or request label Nov 22, 2024
@jamestexas jamestexas self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant