Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you please port it to Firefox? #68

Open
andreicristianpetcu opened this issue Mar 5, 2020 · 4 comments
Open

Can you please port it to Firefox? #68

andreicristianpetcu opened this issue Mar 5, 2020 · 4 comments
Assignees

Comments

@andreicristianpetcu
Copy link

Firefox has almost the same APIs as Chrome https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Browser_support_for_JavaScript_APIs

Most extensions take minutes to port https://vimeo.com/241435808

@sbrudz
Copy link
Contributor

sbrudz commented Mar 5, 2020

Firefox is definitely on our todo list. We probably won't have bandwidth to work on it until the Spring, though.

@sbrudz
Copy link
Contributor

sbrudz commented May 15, 2020

As noted in the PR above, this is partially working on Firefox. The main issue remaining is that the Just Not Sorry button does not appear because we're using the chrome.declarativecontent API, which Firefox doesn't support. The workaround is to use the pageAction API instead.

Here are the steps remaining to get JNS fully ported to Firefox:

  • convert the background.js code to use the pageAction API so that the icon appears on Firefox
  • install the polyfill and switch from using chrome to browser
  • add automated browser test case for firefox (requires Add automated "compose new" E2E web test for Chrome #90)
  • set up extension on firefox store
  • set up automated publishing process for beta
  • set up automated publishing process for master

@thom4parisot
Copy link

I would be quite happy to have a go at it. It would be a first step prior to poking around multi language (eg: for French language).

@sbrudz
Copy link
Contributor

sbrudz commented Nov 15, 2024

That would be great, @thom4parisot. I'd be happy to review a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants