Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count STOPPING state ECS tasks #774

Merged
merged 2 commits into from
May 10, 2023
Merged

Count STOPPING state ECS tasks #774

merged 2 commits into from
May 10, 2023

Conversation

essa
Copy link
Contributor

@essa essa commented May 9, 2023 •
edited
Loading

Resolves #772

And fixed error handling.

@degikko degikko requested a review from Maduranga May 9, 2023 08:07
@degikko
Copy link

degikko commented May 9, 2023

@Maduranga can you help us review this PR, please?

Maduranga
Maduranga approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@Maduranga Maduranga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you.

@essa essa merged commit b4ad957 into master May 10, 2023
@essa essa mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maduranga Maduranga Maduranga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lifecycle hook doesn't wait for termination of tasks
3 participants
@essa @degikko @Maduranga