Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature payload cleartext generation deviates from spec #284

Open
cohix opened this issue Jan 28, 2022 · 1 comment
Open

Signature payload cleartext generation deviates from spec #284

cohix opened this issue Jan 28, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@cohix
Copy link

cohix commented Jan 28, 2022

The signing spec says:
The signature is computed by concatenating the following pieces of data together in a line-separated (\n) UTF-8 string: by, name, version, role, at and the label.sha256 of each parcel:

However the Bindle server does not include the at value when generating its version of the payload, and so a client who follows the spec creates a signature that is invalid in the eyes of the server.

@thomastaylor312 thomastaylor312 added the bug Something isn't working label Jan 28, 2022
@thomastaylor312
Copy link
Contributor

Good catch on this. We'll fix it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants