chore: mark as compatible with rails 7.1 #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
furkan-instrumentl
approved these changes
Oct 18, 2023
|
LGTM 🎉 |
|
Hi, |
|
@elalemanyo switch to Pagy for pagination, you'll be much happier |
|
Thanks. Will be done by relaxing Rails version constraint: #197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally and it seems to work with no other changes
I had to convert the Dockerfile to use Debian-based images instead of Alpine because current versions of
nokogiriinclude binaries in them that link against glibc and fail to run when ruby is linked against musl libc.