Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quotes in Card Names not Correctly Escaped in CSVs #2393

Open
ahmattox opened this issue May 11, 2023 · 0 comments · May be fixed by #2477
Open

Quotes in Card Names not Correctly Escaped in CSVs #2393

ahmattox opened this issue May 11, 2023 · 0 comments · May be fixed by #2477

Comments

@ahmattox
Copy link
Contributor

Describe the bug
Quote characters in card names aren't correctly escaped in CSVs so they aren't correctly imported elswhere. The first quote is escaped, but the second is not.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new Cube.
  2. Add Henzie "Toolbox" Torre to the cube.
  3. Export a CSV of the cube
  4. Open the CSV in a text editor

Expected behavior
All double quotes should be escaped by replacing them with two consecutive double quote characters.

Screenshots
Screenshot 2023-05-11 at 4 01 12 PM

name,CMC,Type,Color,Set,Collector Number,Rarity,Color Category,status,Finish,maybeboard,image URL,image Back URL,tags,Notes,MTGO ID
"Giant Growth",,"Instant",,"lea","197",common,g,Owned,,false,,,"","",
"Henzie ""Toolbox" Torre",,"Legendary Creature - Devil Rogue",,"ncc","2",mythic,m,Owned,,false,,,"","",
KaelenProctor added a commit to KaelenProctor/CubeCobra that referenced this issue Nov 1, 2024
@KaelenProctor
Fixes dekkerglen#2393 - Replace all double-quotes in card names, not …
4f67804 
…just the

first.
@KaelenProctor KaelenProctor linked a pull request Nov 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace all double-quotes in card names, not just the first KaelenProctor/CubeCobra
1 participant
@ahmattox