You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The part of code that checks overrides for determinations, seem to always look into the id -- while (the features bucket_type is guid) one would the keys on overrides to represent guids.
Solution
There is an easy solution of deciding to use id or guid here -- however backwards compatibility is a big issue here. Two ways I can imagine we get around this:
Do a major release and warn about the breaking change.
Check for both id and guid -- bit hacky but in reality these two never clash, so... we should be fine?
What
The part of code that checks overrides for determinations, seem to always look into the
id
-- while (the featuresbucket_type
isguid
) one would the keys onoverrides
to representguid
s.Solution
There is an easy solution of deciding to use
id
orguid
here -- however backwards compatibility is a big issue here. Two ways I can imagine we get around this:id
andguid
-- bit hacky but in reality these two never clash, so... we should be fine?Thoughts?
/cc @jphastings
The text was updated successfully, but these errors were encountered: