Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override is broken for guid features #54

Open
mvalipour opened this issue Oct 23, 2018 · 0 comments
Open

Override is broken for guid features #54

mvalipour opened this issue Oct 23, 2018 · 0 comments

Comments

@mvalipour
Copy link

mvalipour commented Oct 23, 2018

What

The part of code that checks overrides for determinations, seem to always look into the id -- while (the features bucket_type is guid) one would the keys on overrides to represent guids.

Solution

There is an easy solution of deciding to use id or guid here -- however backwards compatibility is a big issue here. Two ways I can imagine we get around this:

  1. Do a major release and warn about the breaking change.
  2. Check for both id and guid -- bit hacky but in reality these two never clash, so... we should be fine?

Thoughts?
/cc @jphastings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant