feat: add lazy loading to emoji image list #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
|
Hi @Vuurvos1, Thanks so much for taking this issue; I was thinking of adding a lazy load to the full group; for example, when Another concern is that it may not be a good idea to force lazy-loading for all images; instead we can add an option/prop like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Improve image loading performance by only loading images that are in view
Summary
Added
loading="lazy"to emoji images in bodyRelevant Technical Choices
To-do
User-facing changes
Nothing visual changes for the end user
Checklist
Fixes #17