fix 'unreachable' warnings in ParsedLogPath

[zachschuermann]

warnings happened before when we did cargo t -p delta_kernel. this PR just uses developer-visibility and adds a few #[allow(unused)]/ dead code

   Compiling delta_kernel v0.3.1 (/Users/zach.schuermann/dev/delta-kernel-rs/kernel)
warning: fields `filename` and `extension` are never read
  --> kernel/src/path.rs:45:9
   |
43 | struct ParsedLogPath<Location: AsUrl = FileMeta> {
   |        ------------- fields in this struct
44 |     pub location: Location,
45 |     pub filename: String,
   |         ^^^^^^^^
46 |     pub extension: String,
   |         ^^^^^^^^^
   |
   = note: `ParsedLogPath` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default

warning: method `is_unknown` is never used
   --> kernel/src/path.rs:159:12
    |
74  | impl<Location: AsUrl> ParsedLogPath<Location> {
    | --------------------------------------------- method in this implementation
...
159 |     pub fn is_unknown(&self) -> bool {
    |            ^^^^^^^^^^

warning: unreachable `pub` item
  --> kernel/src/path.rs:76:5
   |
76 |     pub fn try_from(location: Location) -> DeltaResult<Option<ParsedLogPath<Location>>> {
   |     ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |     |
   |     help: consider restricting its visibility: `pub(crate)`
   |
note: the lint level is defined here
  --> kernel/src/lib.rs:46:5
   |
46 |     unreachable_pub,
   |     ^^^^^^^^^^^^^^^

warning: unreachable `pub` item
   --> kernel/src/path.rs:147:5
    |
147 |     pub fn is_commit(&self) -> bool {
    |     ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |     |
    |     help: consider restricting its visibility: `pub(crate)`

warning: unreachable `pub` item
   --> kernel/src/path.rs:151:5
    |
151 |     pub fn is_checkpoint(&self) -> bool {
    |     ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |     |
    |     help: consider restricting its visibility: `pub(crate)`

warning: unreachable `pub` item
   --> kernel/src/path.rs:159:5
    |
159 |     pub fn is_unknown(&self) -> bool {
    |     ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |     |
    |     help: consider restricting its visibility: `pub(crate)`

warning: `delta_kernel` (lib) generated 6 warnings (run `cargo fix --lib -p delta_kernel` to apply 4 suggestions)
warning: `delta_kernel` (lib test) generated 4 warnings (4 duplicates)

[scovich]

Thanks for figuring this out!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.86%. Comparing base (0fdb40a) to head (9b34c55).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   76.54%   76.86%   +0.32%     
==========================================
  Files          47       47              
  Lines        9384     9436      +52     
  Branches     9384     9436      +52     
==========================================
+ Hits         7183     7253      +70     
+ Misses       1799     1789      -10     
+ Partials      402      394       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nicklan]

yeah thanks, this was on my list of paper cuts to fix