remove log_replay_iter and process_batch in scan::log_replay

[zachschuermann]

as titled, leftover code we can clean up. and remove dependency on either!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.34%. Comparing base (313272e) to head (32319fa).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   77.99%   78.34%   +0.34%     
==========================================
  Files          49       49              
  Lines       10328    10282      -46     
  Branches    10328    10282      -46     
==========================================
  Hits         8055     8055              
+ Misses       1821     1775      -46     
  Partials      452      452              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nicklan]

setup_batch_process is now only called by process_scan_batch. It's maybe okay that it's in its own function, be we should update it to be (maybe) called get_scan_adds and update the comment.

[scovich]

setup_batch_process is now only called by process_scan_batch. It's maybe okay that it's in its own function, be we should update it to be (maybe) called get_scan_adds and update the comment.

I'm in the middle of prototyping a complete rework of this logic that would depend on this change. Let's pick up naming issues there?

[scovich]

Yay for deletes!