Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actually check arrow. depend on >=53 #413

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

nicklan
Copy link
Collaborator

@nicklan nicklan commented Oct 21, 2024

This fixes three issues:

  1. The integration test was not enabling enough features to actually test arrow enough. Change it so it does
  2. The above caught that we actually don't support arrow 52.x because the various min/max_opt functions don't exist there. See https://docs.rs/parquet/53.1.0/parquet/file/statistics/struct.ValueStatistics.html#method.max and note the deprecation since 53 note.
  3. Parquet depends on object_store. So we also need to be flexible on object_store. Right now I'm locking it to the 0.11 series (the latest).

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.85%. Comparing base (cd53bc1) to head (408ce2c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   78.85%   78.85%           
=======================================
  Files          51       51           
  Lines       10640    10640           
  Branches    10640    10640           
=======================================
  Hits         8390     8390           
  Misses       1781     1781           
  Partials      469      469           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but did delta-rs sort out the polars dependency that prevented them from upgrading to arrow-53?

@nicklan
Copy link
Collaborator Author

nicklan commented Oct 22, 2024

LGTM, but did delta-rs sort out the polars dependency that prevented them from upgrading to arrow-53?

See delta-io/delta-rs#2886 for all the fun they are having with upgrading.

@nicklan nicklan merged commit 6e8bd3e into delta-io:main Oct 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants