Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ScanCallback take a struct and update callback function #547

Open
OussamaSaoudi-db opened this issue Nov 27, 2024 · 1 comment
Open

Make ScanCallback take a struct and update callback function #547

OussamaSaoudi-db opened this issue Nov 27, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@OussamaSaoudi-db
Copy link
Collaborator

Please describe why this is necessary.

ScanCallback currently takes all the fields of a ScanFile as parameters. This can be cumbersome to write and call.

Describe the functionality you are proposing.

Change ScanCallback so that it takes a struct ScanFile containing all the fields.

To make this change work with FFI, you must also change the rust_callback here to take the ScanFile struct, dustructure it, and pass its fields to the c callback.

Additional context

No response
@OussamaSaoudi-db OussamaSaoudi-db added enhancement New feature or request good first issue Good for newcomers labels Nov 27, 2024
@cg-cognition cg-cognition mentioned this issue Dec 7, 2024
Open
@cg-cognition
Copy link

Took a pass at fixing this! (#576) Let me know what you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OussamaSaoudi-db @cg-cognition