You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
An engine may eagerly perform validation to check that the columns in the expression exist in the input schema, or that the output types of the expression match the output schema. However, the engine cannot return a failure because get_evaluator(...) is infallible.
Describe the functionality you are proposing.
Change the signature of ExpressionHandler::get_evaluator to the following:
Hey @OussamaSaoudi-db , I took a pass at fixing this issue (#577). I think there's a still a few questions around handling error propagation, would really appreciate your review!
Please describe why this is necessary.
One can construct an
ExpressionEvaluator
given anengine
, input schema, expression transform, and output schema:An engine may eagerly perform validation to check that the columns in the expression exist in the input schema, or that the output types of the expression match the output schema. However, the engine cannot return a failure because
get_evaluator(...)
is infallible.Describe the functionality you are proposing.
Change the signature of
ExpressionHandler::get_evaluator
to the following:Fix compiler errors at all call sites in the code and testss.
Additional context
No response
The text was updated successfully, but these errors were encountered: