use reference

Author: ion-elgreco

crates/deltalake-core/src/operations/delete.rs

@@ -63,7 +63,7 @@ pub struct DeleteBuilder {
     app_metadata: Option<HashMap<String, serde_json::Value>>,
 }
 
-#[derive(Default, Debug, Clone, Serialize)]
+#[derive(Default, Debug, Serialize)]
 /// Metrics for the Delete Operation
 pub struct DeleteMetrics {
     /// Number of files added
@@ -415,7 +415,7 @@ mod tests {
         let extra_info = last_commit.info.clone();
         assert_eq!(
             extra_info["operationMetrics"],
-            serde_json::to_value(metrics.clone()).unwrap()
+            serde_json::to_value(&metrics).unwrap()
         );
 
         // rewrite is not required

crates/deltalake-core/src/operations/filesystem_check.rs

@@ -45,7 +45,7 @@ pub struct FileSystemCheckBuilder {
 }
 
 /// Details of the FSCK operation including which files were removed from the log
-#[derive(Debug, Clone, Serialize)]
+#[derive(Debug, Serialize)]
 pub struct FileSystemCheckMetrics {
     /// Was this a dry run
     pub dry_run: bool,
@@ -160,10 +160,9 @@ impl FileSystemCheckPlan {
         };
 
         let mut app_metadata = HashMap::new();
-        let fsck_metrics = serde_json::to_value(metrics.clone());
 
         app_metadata.insert("readVersion".to_owned(), snapshot.version().into());
-        if let Ok(map) = fsck_metrics {
+        if let Ok(map) = serde_json::to_value(&metrics) {
             app_metadata.insert("operationMetrics".to_owned(), map);
         }
 

crates/deltalake-core/src/operations/merge/mod.rs

@@ -553,7 +553,7 @@ impl MergeOperationConfig {
     }
 }
 
-#[derive(Default, Serialize, Clone, Debug)]
+#[derive(Default, Serialize, Debug)]
 /// Metrics for the Merge Operation
 pub struct MergeMetrics {
     /// Number of rows in the source data
@@ -1390,9 +1390,7 @@ async fn execute(
 
     app_metadata.insert("readVersion".to_owned(), snapshot.version().into());
 
-    let merge_metrics = serde_json::to_value(metrics.clone());
-
-    if let Ok(map) = merge_metrics {
+    if let Ok(map) = serde_json::to_value(&metrics) {
         app_metadata.insert("operationMetrics".to_owned(), map);
     }
 
@@ -2062,7 +2060,7 @@ mod tests {
         let extra_info = last_commit.info.clone();
         assert_eq!(
             extra_info["operationMetrics"],
-            serde_json::to_value(metrics.clone()).unwrap()
+            serde_json::to_value(&metrics).unwrap()
         );
         assert_eq!(parameters["predicate"], json!("target.id = source.id"));
         assert_eq!(

crates/deltalake-core/src/operations/restore.rs

@@ -60,7 +60,7 @@ impl From<RestoreError> for DeltaTableError {
 }
 
 /// Metrics from Restore
-#[derive(Default, Debug, Clone, Serialize)]
+#[derive(Default, Debug, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct RestoreMetrics {
     /// Number of files removed

crates/deltalake-core/src/operations/update.rs

@@ -78,7 +78,7 @@ pub struct UpdateBuilder {
     safe_cast: bool,
 }
 
-#[derive(Default, Clone, Serialize, Debug)]
+#[derive(Default, Serialize, Debug)]
 /// Metrics collected during the Update operation
 pub struct UpdateMetrics {
     /// Number of files added.
@@ -416,9 +416,7 @@ async fn execute(
 
     app_metadata.insert("readVersion".to_owned(), snapshot.version().into());
 
-    let update_metrics = serde_json::to_value(metrics.clone());
-
-    if let Ok(map) = update_metrics {
+    if let Ok(map) = serde_json::to_value(&metrics) {
         app_metadata.insert("operationMetrics".to_owned(), map);
     }
 
@@ -876,7 +874,7 @@ mod tests {
         let extra_info = last_commit.info.clone();
         assert_eq!(
             extra_info["operationMetrics"],
-            serde_json::to_value(metrics.clone()).unwrap()
+            serde_json::to_value(&metrics).unwrap()
         );
 
         let expected = [