From 99d59dcf9495afbf62a7f8879c628bee2cc79dc0 Mon Sep 17 00:00:00 2001 From: Ion Koutsouris <15728914+ion-elgreco@users.noreply.github.com> Date: Tue, 14 Jan 2025 21:48:31 +0100 Subject: [PATCH] chore: clean up Signed-off-by: Ion Koutsouris <15728914+ion-elgreco@users.noreply.github.com> --- crates/aws/src/storage.rs | 2 +- crates/azure/src/lib.rs | 4 +--- crates/core/Cargo.toml | 2 +- crates/gcp/src/lib.rs | 2 +- crates/lakefs/src/storage.rs | 2 +- 5 files changed, 5 insertions(+), 7 deletions(-) diff --git a/crates/aws/src/storage.rs b/crates/aws/src/storage.rs index d16887a636..a1335afca7 100644 --- a/crates/aws/src/storage.rs +++ b/crates/aws/src/storage.rs @@ -54,7 +54,7 @@ impl ObjectStoreFactory for S3ObjectStoreFactory { } } - let (_scheme, path) = + let (_, path) = ObjectStoreScheme::parse(url).map_err(|e| DeltaTableError::GenericError { source: Box::new(e), })?; diff --git a/crates/azure/src/lib.rs b/crates/azure/src/lib.rs index e4d2d1e555..16f40cfa24 100644 --- a/crates/azure/src/lib.rs +++ b/crates/azure/src/lib.rs @@ -46,14 +46,12 @@ impl ObjectStoreFactory for AzureFactory { ) -> DeltaResult<(ObjectStoreRef, Path)> { let config = config::AzureConfigHelper::try_new(options.as_azure_options())?.build()?; - let (_scheme, path) = + let (_, path) = ObjectStoreScheme::parse(&url).map_err(|e| DeltaTableError::GenericError { source: Box::new(e), })?; let prefix = Path::parse(path)?; - // let (inner, prefix) = parse_url_opts(url, config)?; - let mut builder = MicrosoftAzureBuilder::new().with_url(url.to_string()); for (key, value) in config.iter() { diff --git a/crates/core/Cargo.toml b/crates/core/Cargo.toml index d987415513..e9f7962bb4 100644 --- a/crates/core/Cargo.toml +++ b/crates/core/Cargo.toml @@ -98,7 +98,7 @@ rand = "0.8" z85 = "3.0.5" maplit = "1" sqlparser = { version = "0.53.0" } -humantime = { version = "2.1.0"} +humantime = { version = "2.1.0" } [dev-dependencies] criterion = "0.5" diff --git a/crates/gcp/src/lib.rs b/crates/gcp/src/lib.rs index 3ae3dac245..3bcf9b3f26 100644 --- a/crates/gcp/src/lib.rs +++ b/crates/gcp/src/lib.rs @@ -47,7 +47,7 @@ impl ObjectStoreFactory for GcpFactory { ) -> DeltaResult<(ObjectStoreRef, Path)> { let config = config::GcpConfigHelper::try_new(options.as_gcp_options())?.build()?; - let (_scheme, path) = + let (_, path) = ObjectStoreScheme::parse(&url).map_err(|e| DeltaTableError::GenericError { source: Box::new(e), })?; diff --git a/crates/lakefs/src/storage.rs b/crates/lakefs/src/storage.rs index ea17be4eb3..6aafdd72f1 100644 --- a/crates/lakefs/src/storage.rs +++ b/crates/lakefs/src/storage.rs @@ -92,7 +92,7 @@ impl ObjectStoreFactory for LakeFSObjectStoreFactory { }) .collect::>(); - let (_scheme, path) = + let (_, path) = ObjectStoreScheme::parse(&s3_url).map_err(|e| DeltaTableError::GenericError { source: Box::new(e), })?;