From 9aa301e03c5a404f47ee064a0bd41e16d34012d3 Mon Sep 17 00:00:00 2001 From: Robert Pack Date: Sun, 5 Nov 2023 17:01:42 +0100 Subject: [PATCH] fix: pr comments --- crates/deltalake-core/src/kernel/schema.rs | 8 ++++---- crates/deltalake-core/src/operations/create.rs | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/crates/deltalake-core/src/kernel/schema.rs b/crates/deltalake-core/src/kernel/schema.rs index 72c92f32b8..62b0496419 100644 --- a/crates/deltalake-core/src/kernel/schema.rs +++ b/crates/deltalake-core/src/kernel/schema.rs @@ -447,10 +447,10 @@ impl Display for PrimitiveType { fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { match self { PrimitiveType::String => write!(f, "string"), - PrimitiveType::Long => write!(f, "bigint"), - PrimitiveType::Integer => write!(f, "int"), - PrimitiveType::Short => write!(f, "smallint"), - PrimitiveType::Byte => write!(f, "tinyint"), + PrimitiveType::Long => write!(f, "long"), + PrimitiveType::Integer => write!(f, "integer"), + PrimitiveType::Short => write!(f, "short"), + PrimitiveType::Byte => write!(f, "byte"), PrimitiveType::Float => write!(f, "float"), PrimitiveType::Double => write!(f, "double"), PrimitiveType::Boolean => write!(f, "boolean"), diff --git a/crates/deltalake-core/src/operations/create.rs b/crates/deltalake-core/src/operations/create.rs index a0f0871c1e..1dc9fdf8b2 100644 --- a/crates/deltalake-core/src/operations/create.rs +++ b/crates/deltalake-core/src/operations/create.rs @@ -11,7 +11,6 @@ use super::transaction::commit; use super::{MAX_SUPPORTED_READER_VERSION, MAX_SUPPORTED_WRITER_VERSION}; use crate::errors::{DeltaResult, DeltaTableError}; use crate::kernel::{Action, DataType, Metadata, Protocol, StructField, StructType}; -// use crate::kernel::{SchemaDataType, SchemaField, SchemaTypeStruct}; use crate::protocol::{DeltaOperation, SaveMode}; use crate::storage::DeltaObjectStore; use crate::table::builder::ensure_table_uri;