Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cdc merge union schema order #2919

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

ion-elgreco
Copy link
Collaborator

Description

DataFusion doesn't have unionByName or a relaxed concat, so the before and after schema needs to be in the same order. The before though was getting expressions in different order. So just doing a simple select_columns afterwards to take the after schema order (which has the write projection order)

Related Issue(s)

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.48%. Comparing base (72e344e) to head (c6ba0c8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/operations/merge/mod.rs 75.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2919      +/-   ##
==========================================
+ Coverage   72.47%   72.48%   +0.01%     
==========================================
  Files         131      131              
  Lines       40410    40418       +8     
  Branches    40410    40418       +8     
==========================================
+ Hits        29287    29299      +12     
  Misses       9238     9238              
+ Partials     1885     1881       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ion-elgreco ion-elgreco added this pull request to the merge queue Sep 29, 2024
Merged via the queue into delta-io:main with commit 8e4c23b Sep 29, 2024
24 checks passed
@ion-elgreco ion-elgreco deleted the fix/cdc_merge_planning branch September 29, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
2 participants