Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup_expired_logs_for doesn't update logSegment after removal #3062

Open
ion-elgreco opened this issue Dec 16, 2024 · 0 comments · May be fixed by #3064
Open

cleanup_expired_logs_for doesn't update logSegment after removal #3062

ion-elgreco opened this issue Dec 16, 2024 · 0 comments · May be fixed by #3064
Labels
bug Something isn't working

Comments

@ion-elgreco
Copy link
Collaborator

ion-elgreco commented Dec 16, 2024 •
edited
Loading

When we call cleanup_expired_logs_for, we don't update the log_segment of the snapshot. So in the cleanup_metadata call or post_commit_hook we might remove logs, but still reference those deleted logs in the snapshot, which is incorrect.

REF: #3057
@ion-elgreco ion-elgreco added the bug Something isn't working label Dec 16, 2024
@ion-elgreco ion-elgreco linked a pull request Dec 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pop logs in log segment after cleaning up logs ion-elgreco/delta-rs
1 participant
@ion-elgreco