fix: allow more than 15 concurrent transactions to have been committed #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
rtyler
changed the title
a number of our transitive dependencies have forced the upgrade in patch versions of the Minimum Supported Rust Version (MSRV) and broke builds from crates.io and `main` on Rust 1.80. 😒 This change upgrades us to 1.81 but bumps to 0.23 in the process. Signed-off-by: R. Tyler Croy <[email protected]>
…r use This will help retry logic associated with the logstore to directly find the appropriate next c ommit Related to #3306 Signed-off-by: R. Tyler Croy <[email protected]>
There are high-concurrency scenarios where multiple writers may have committed versions to the log since the current process' state was loaded. Because of the `snapshot.version() + 1` and retry logic in the transaction commit operation, this would result in failures if more than 15 versions had been committed since the table state had been loaded. This approach fetches the latest known version on the table prior to committing the transaction, and if the latest version has shifted, it will perform a conflict check with the versions that have since been committed. Fixes delta-io#3066 Signed-off-by: R. Tyler Croy <[email protected]> Sponsored-by: Scribd Inc
rtyler
force-pushed
the
logstore-retry-backoff
branch
from
28fc839 to
8e308e2
Compare
|
Note: This pull request is rebased on #3069 so that the CI would pass. I would expect the other pull request to be merged first |
rtyler
requested review from
wjones127,
fvaleye,
roeap,
ion-elgreco and
hntd187
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3067 +/- ##
========================================
Coverage 72.41% 72.41%
========================================
Files 128 128
Lines 41314 41007 -307
Branches 41314 41007 -307
========================================
- Hits 29918 29696 -222
- Misses 9426 9429 +3
+ Partials 1970 1882 -88 ☔ View full report in Codecov by Sentry. |
ion-elgreco
approved these changes
Dec 20, 2024
|
Looks good! Just a question, the issue also mentions to also introduce exponential backoff. But I don't see that being implemented here, are you addressing that in another PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are high-concurrency scenarios where multiple writers may have committed versions to the log since the current process' state was loaded. Because of the
snapshot.version() + 1and retry logic in the transaction commit operation, this would result in failures if more than 15 versions had been committed since the table state had been loaded.This approach fetches the latest known version on the table prior to committing the transaction, and if the latest version has shifted, it will perform a conflict check with the versions that have since been committed.
Fixes #3066