From 69c29df4eb3220579589979c164e231763abbf3a Mon Sep 17 00:00:00 2001 From: Xin Huang Date: Wed, 22 Jan 2025 13:08:14 -0800 Subject: [PATCH] update comments --- .../src/main/java/io/delta/kernel/internal/replay/CRCInfo.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/kernel-api/src/main/java/io/delta/kernel/internal/replay/CRCInfo.java b/kernel/kernel-api/src/main/java/io/delta/kernel/internal/replay/CRCInfo.java index 9a015de43a..b2d95ec91e 100644 --- a/kernel/kernel-api/src/main/java/io/delta/kernel/internal/replay/CRCInfo.java +++ b/kernel/kernel-api/src/main/java/io/delta/kernel/internal/replay/CRCInfo.java @@ -31,9 +31,9 @@ public class CRCInfo { public static Optional fromColumnarBatch( Engine engine, long version, ColumnarBatch batch, int rowId, String crcFilePath) { - // fromColumnVector already takes care of nulls Protocol protocol = Protocol.fromColumnVector(batch.getColumnVector(PROTOCOL_ORDINAL), rowId); Metadata metadata = Metadata.fromColumnVector(batch.getColumnVector(METADATA_ORDINAL), rowId); + // protocol and metadata are nullable per fromColumnVector's implementation. if (protocol == null || metadata == null) { logger.warn("Invalid checksum file missing protocol and/or metadata: {}", crcFilePath); return Optional.empty();