Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doveauth: log when a new account is created #349

Merged
merged 1 commit into from
Jul 8, 2024
Merged

doveauth: log when a new account is created #349

merged 1 commit into from
Jul 8, 2024

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Jul 8, 2024

No description provided.

@link2xt link2xt force-pushed the link2xt/doveauth-logs branch from 0a7ed5d to 89cee88 Compare July 8, 2024 19:58
@link2xt link2xt requested review from missytake, hagenest and hpk42 July 8, 2024 19:58
@link2xt
Copy link
Contributor Author

link2xt commented Jul 8, 2024

I want to use mtail instead of scraping /metrics to count new accounts, both CI and non-CI.
See #328 for details.

@hpk42 hpk42 merged commit 62c60d3 into main Jul 8, 2024
4 of 5 checks passed
@hpk42 hpk42 deleted the link2xt/doveauth-logs branch July 8, 2024 22:24
hagenest
hagenest approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@hagenest hagenest left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good👍

I wonder if we want to have different log levels someday

edit: seems like Holger was faster :D

@link2xt
Copy link
Contributor Author

link2xt commented Jul 8, 2024

I wonder if we want to have different log levels someday

I don't think anyone cares about log levels when using journald. It saves PRIORITY for compatibility or something, but I have never seen anyone using it for filtering and not going to use it myself.

@link2xt link2xt mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hagenest hagenest hagenest approved these changes

@hpk42 hpk42 hpk42 approved these changes

@missytake missytake Awaiting requested review from missytake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@link2xt @hpk42 @hagenest