Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

displaynames do not update #6115

Closed
dkg opened this issue Jul 12, 2024 · 6 comments · Fixed by #6137
Closed

displaynames do not update #6115

dkg opened this issue Jul 12, 2024 · 6 comments · Fixed by #6137
Assignees
Labels
bug Something is not working

Comments

@dkg
Copy link
Contributor

dkg commented Jul 12, 2024

  • Delta Chat version: 1.46.6

I was trying to replicate deltachat/deltachat-android#3155 and deltachat/interface#71 with a colleague using iOS, and found that my updated displayname didn't show up on their device.

I would have expected it to show up for them, the way it did on Desktop and Android. But it did not. my displayname for them remains "dkg".

Conversely, when they change their displayname, i can see the updated display name on both Android and Desktop systems.

@dkg dkg added the bug Something is not working label Jul 12, 2024
@r10s r10s removed the bug Something is not working label Jul 13, 2024
@r10s

This comment was marked as off-topic.

@r10s r10s closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2024
@r10s r10s added the bug Something is not working label Jul 13, 2024
@r10s

This comment was marked as off-topic.

@r10s r10s reopened this Jul 13, 2024
@zeitschlag
Copy link

A quick workaround is to go to the user's profile (1. Go to the chat. 2. press their profile-icon. 3. Edit) and remove the name. Afterwards the display name should be updated automatically again if the other user changes their name.

@missytake
Copy link
Contributor

same issue appears on desktop: deltachat/deltachat-desktop#4045

@r10s
Copy link
Member

r10s commented Oct 26, 2024

and i just tested on android, this does not work as well. there might have been a degradation recently, i am pretty sure, that used to work.

to reproduce, eg. Desktop to Android:

  1. create fresh (!) profile with name "Alice" on Desktop
  2. create fresh (!) profile with name "Bob" on Android
  3. let Bob scan Alice's QR code
  4. for Alice, at "Settings / Edit Profile / Your Name" change to "AliceTwo"
  5. send a message from Alice to Bob

=> Bob still shows the old name. this is not a refresh issue, even after restart, get_Bob does receive the new name, but it is not returned by dc_contact_get_display_name().

(we could write a test for that)

still, it was received, as dc_contact_get_auth_name() is correct, see the following "edit name" dialog saying 'enter a name to be shown instead of "AliceTwo"'.

maybe, somewhere on initial receiving a copy of the "auth name" is written to the "edited name" where it should not have been.

tested using desktop1.47.0(core1.147.1) and android 1.48.1(core1.148.4)

@r10s r10s transferred this issue from deltachat/deltachat-ios Oct 26, 2024
@iequidoo iequidoo self-assigned this Oct 30, 2024
@iequidoo
Copy link
Collaborator

iequidoo commented Oct 31, 2024

Reproduced it with a Rust test, the contact name comes from QR code. The reason is 3f9242a (see Origin::UnhandledQrScan). Seems this was just hidden over years and appeared because of some recent changes. EDIT: I can't get why Origin::UnhandledQrScan mustn't bring the name from QR code to authname and puts it into name instead. CC @link2xt

EDIT:

// from the QR-code scan (potentially from the address book of their other phone), then name

-- so, basically it's because QR codes are generated not only by Delta Chat.

iequidoo added a commit that referenced this issue Oct 31, 2024
#6115)

3f9242a saves name from all QR codes to `name` (i.e. manually edited name), but for SecureJoin QR
codes the name should be saved to `authname` because such QR codes are generated by the
inviter. Other QR codes may be generated locally and not only by Delta Chat, so the name from them
mustn't go to `authname` and revealed to the network or other contacts.
iequidoo added a commit that referenced this issue Oct 31, 2024
#6115)

3f9242a saves name from all QR codes to `name` (i.e. manually edited name), but for SecureJoin QR
codes the name should be saved to `authname` because such QR codes are generated by the
inviter. Other QR codes may be generated locally and not only by Delta Chat, so the name from them
mustn't go to `authname` and be revealed to the network or other contacts.
iequidoo added a commit that referenced this issue Nov 1, 2024
#6115)

3f9242a saves name from all QR codes to `name` (i.e. manually edited name), but for SecureJoin QR
codes the name should be saved to `authname` because such QR codes are generated by the
inviter. Other QR codes may be generated locally and not only by Delta Chat, so the name from them
mustn't go to `authname` and be revealed to the network or other contacts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
5 participants