New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take components into account in .map() #6

Open

delucis opened this issue Apr 26, 2018 · 0 comments

Assignees

Labels

bug

Owner

delucis commented Apr 26, 2018

.map() does not take components into account, causing problems:

If a glyph references a component, but that component is mapped and renamed, the reference will break
If a glyph references a component and is mapped but the component isn’t, the component will be missing and the reference will break
If a subset glyph references a component not also in the subset, the reference will break

A check should be added that tests:

Does a mapped glyph reference a component? Then the component should be preserved.
Is a mapped glyph itself referenced as a component? If the glyph referencing it will be preserved, its reference should be updated.

The text was updated successfully, but these errors were encountered:

delucis added the bug label

delucis self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment