Reintroduce demisto-sdk to the new docker registry proxy #4655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changelog(s) in markdown:
|
samuelFain
commented
Nov 11, 2024
Comment on lines
+576
to
+593
| logger.info( | ||
| "Running in a GitLab CI environment with custom DOCKER_IO environment variable, Trying to prase a DockerHub Google Artifact Registry from DOCKER_IO environment variable." | ||
| ) | ||
| if parsed_dockerhub_proxy_api_url := get_dockerhub_artifact_registry_url( | ||
| DOCKER_IO | ||
| ): | ||
| return parsed_dockerhub_proxy_api_url | ||
| else: | ||
| logger.info( | ||
| "Could not parse a valid API URL from the DOCKER_IO environment variable." | ||
| ) | ||
| except Exception as e: | ||
| logger.info( | ||
| f"Could not parse a valid API URL from the DOCKER_IO environment variable, Error: {str(e)} " | ||
| ) | ||
|
|
||
| logger.info(f"using provided or default registry, {default_registry=}") | ||
| return registry or default_registry |
There was a problem hiding this comment.
Reminder: change logger.info to logger.debug where needed before merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reintroduce docker registry proxy support to demisto-sdk after a previous revert.
Merged the original PR #4528 to this one.
Infra MR number: 584